← All reports

Remove display list ImageBuffers

Component: WebKit GPU process rendering | 4f8765a

Source/WebCore/platform/graphics/GraphicsContext.cpp

case RenderingMode::Accelerated:
case RenderingMode::Unaccelerated:
- case RenderingMode::DisplayList:
return renderingMode();
case RenderingMode::PDFDocument:
+ case RenderingMode::DisplayList:
+ // Compatible buffers are drawn into and then read back, masked or filtered, which needs pixels.
return RenderingMode::Unaccelerated;

Source/WebCore/platform/graphics/ImageBuffer.cpp

- case RenderingMode::DisplayList:
- return ImageBuffer::create<ImageBufferDisplayListBackend>(size, resolutionScale, colorSpace, pixelFormat, purpose, { });
-
case RenderingMode::PDFDocument:
+ case RenderingMode::DisplayList:
+ // FIXME: PDFDocument and DisplayList are only meaningful for a GraphicsContext. ...
RELEASE_ASSERT_NOT_REACHED();

An ImageBuffer is normally a raster surface that can be read back as pixels and used as a mask or filter source. During remote snapshotting (used for site-isolated view-transition captures), the recorder context reports RenderingMode::DisplayList, and compatible buffers created while painting inherited that mode, which produced display-list buffers that cannot answer getPixelBuffer(). This commit removes ImageBufferDisplayListBackend and ImageBufferRemoteDisplayListBackend and maps DisplayList contexts to Unaccelerated compatible buffers. RemoteRenderingBackend::allocateImageBuffer() now rejects DisplayList alongside PDFDocument.

A GPU-process object type reachable over IPC disappears, along with a RELEASE_ASSERT crash when a luminance mask was read back during a cross-site remote snapshot.

The new rejection must cover every entry point that carries a rendering mode into a buffer or backend factory (CreateImageBuffer, CreateMappableImageBuffer, image buffer set configuration). The DisplayList/PDFDocument checks were removed from RemoteImageBuffer::getPixelBuffer()/putPixelBuffer(), so those paths now depend entirely on that upfront rejection. Look for callers that read a context's rendering mode directly beyond the changed StyleFilterImage, ScrollbarThemeMac and DataDetectorHighlight. Snapshot paths that now rasterize vector content may shift size, scale or memory behavior, and masks, filters and SVG patterns during site-isolation capture were a GPU-process crash path. The removed ipc/move-to-image-buffer-cross-thread-font-crash test is a reminder to check similar cross-backend move and serialization paths for other buffer types (createBackendForSerializedBuffer).