[WebXR Layers] Implement Cube layer

bccc465

WebXR Layers let web content submit compositor layers directly to the XR runtime, bypassing normal framebuffer composition. WebKit splits XR work between the WebProcess (JS, GL calls) and the UIProcess (owns the XR session, talks to OpenXR). Cube layers are uniquely difficult: GL cube maps have 6 faces and cannot be shared across processes via DMABuf like ordinary 2D textures.

Source/WebCore/Modules/webxr/WebXRWebGLSwapchain.cpp

 PlatformGLObject WebXRWebGLStaticImageSwapchain::currentTextureAtIndex(uint32_t cubeIndex)
 {
     if (m_imageAttributes.textureType != GL::TEXTURE_CUBE_MAP)
         return currentTexture();
     size_t index = m_currentImageIndex * m_imageAttributes.arrayLength + cubeIndex;
     RELEASE_ASSERT(m_textures.size() > index);
     return m_textures[index];
 }

This commit implements XRCubeLayer end-to-end: WebCore-side swapchain management, a new WebXRWebGLMultiTextureSwapchain abstract base generalizing multi-face/array texture handling, cross-process serialization of cube layer data, and an OpenXR backend using XR_KHR_composition_layer_cube. The 6 faces are serialized into side-by-side 2D textures for IPC transfer, then reconstructed in the UIProcess via reconstructCubeFaces(). Stereo mode doubles this to 12 faces across two cube maps. Both mono/stereo and texture-array-backed cube layers are supported.

Significance

This is substantial new GPU texture-management code crossing the WebProcess/UIProcess boundary, with non-trivial index arithmetic over multi-face cube maps — exactly where integer overflow or bounds-confusion bugs tend to hide.

Audit directions

Aaaaaaaaaaaaaaaaaaaaaaa Aaaaaaaa Aaaaaa a Aaaaaaaaaaaaaaaaaaa a Aaaaaaaaaaaaaaaaaaaaaaaaaaaaa a Aaaaaaaaaa Aaaa Aaaaaaaaaaaaaaaaaaa Aaaaaaaa a Aa Aaaaaaaaaaaaa Aa Aaaaa Aaa Aaaaaaaaaaaaaaaaaaaaa Aaaaaaaaaaaa Aaa Aaaaaaaaaaaaaa Aaa Aaaaaaaa Aaaaaa Aaa Aaaaaaaaaaaaaaaaa Aaaaaaaaa Aa Aaaaaaaaaaaaaaaaaaa Aaaaaa Aa Aaaaaaaaaaaaaaaaaaaaa Aaa Aaaaaaa Aaaaaaaa Aa a Aaaaaaaaaaaaaaaaaaaaaaaa Aaaaaaaa Aaaa Aaaaaaaa Aa Aaaaaaaaaa Aaaaaaa a Aaaaaaaaaa Aaaaaa a Aaaaaaaa Aaaaa Aaaaaaa a Aaaaa Aaaaaaaa Aaaaaa Aaaaa Aaaaa Aaaaaaaaaaaaa Aa Aaa Aaa Aaaaaaa Aaa Aaaaaaa Aaa Aaaaaaaaa Aa a Aa Aaa Aaaa Aaaaaaaaaa Aaaa Aaa Aaaaa Aaaaaaaaaa Aaa Aaaaaaaaaaaaaaaaaaaa Aaa Aaa Aaa Aaaaaaaaaaaaa Aaaa Aa Aaaaaaaaaaaaaaaaaaaaaaaaaaaaa Aaa Aaaaaaaaaaaaaaa Aa a Aaaaa Aaaaaaaaaaaaa Aaaaaaa Aaaaa Aaaaaaaa

🔒

New multi-face index arithmetic and a signed-to-unsigned cast in the texture lookup path have audit-worthy edge cases.

Subscribe to read more