IDBIndex::getAllRecords() Implementation

fc3f6a3

Source/WebCore/Modules/indexeddb/IDBRecord.idl

+interface IDBRecord {
+    readonly attribute any key;
+    readonly attribute any primaryKey;
+    readonly attribute any value;
+};

Source/WebCore/bindings/js/JSIDBRecordCustom.cpp

+JSValue JSIDBRecord::value(JSGlobalObject& lexicalGlobalObject) const
+{
+    auto& vm = lexicalGlobalObject.vm();
+    auto scope = DECLARE_THROW_SCOPE(vm);
+    auto* idbRecord = wrapped();
+    auto result = deserializeIDBValueWithKeyInjection(lexicalGlobalObject,
+        idbRecord->value(), idbRecord->primaryKey(), idbRecord->keyPath());
+    RETURN_IF_EXCEPTION(scope, { });
+    return result;
+}

Source/WebCore/Modules/indexeddb/server/SQLiteIDBBackingStore.cpp

+if (type == IndexedDB::GetAllType::Records) {
+    result.addKey(WTFMove(indexKey));
+    result.addPrimaryKey(WTFMove(primaryKey));  // NEW
+    result.addValue(WTFMove(value));
+}

IndexedDB in WebKit is implemented across several layers: JS bindings convert internal IDBKeyData/IDBValue types to JS values; the mid-layer (IDBIndex, IDBTransaction) manages requests and communicates results through IDBGetAllResult; the backing store (SQLiteIDBBackingStore) runs SQL queries and populates results; and IPC serialization carries these across process boundaries. This commit implements IDBIndex::getAllRecords() per the W3C spec, returning arrays of IDBRecord objects with key, primaryKey, and value properties.

A critical semantic distinction matters: in the existing Keys/Values cases, the "key" in the result is actually the primary key of the object store record, whereas in the new Records case, "key" is the index key and "primaryKey" is separately the object store record's key — a subtle inversion that must be consistently applied across all layers. The value getter on JSIDBRecord calls deserializeIDBValueWithKeyInjection() to reconstruct in-line-keyed objects at property-access time, the same deserialization path used in JSIDBRequest that has historically been a source of bugs.

JS caller
  └─► IDBIndex::getAllRecords(IDBGetAllOptions)
            │  doGetAllShared(GetAllType::Records)
            ▼
      IDBTransaction::requestGetAllObjectStoreRecords
            │
            ▼
      SQLiteIDBBackingStore::getAllIndexRecords
            │  key       → index key
            │  primaryKey → object store key     ← NEW semantics
            │  value     → serialized IDBValue
            ▼
      IDBGetAllResult { keys[], primaryKeys[], values[] }
            │
      JSIDBRecord::{key,primaryKey,value} custom getters
            └─ value: deserializeIDBValueWithKeyInjection()

Significance

This is new JS-accessible API surface spanning the full IndexedDB stack — JS bindings, IPC serialization, and SQLite backend — each layer introducing new code paths that handle untrusted data.

Audit directions

a Aaaaaaa Aaaaaaaaaaaa Aaaaaaaaaaaaaaaaa Aaa Aaaaaaa Aaaaa Aaaaaaaa Aaaaaa Aaaaaa Aaaaaaaaaaaa Aaaaaaaa Aaa Aaaa Aaaa Aaaaaaaaa Aaa Aaa Aaa Aaaaaaa a Aaaaa Aaaaaaaa Aaaaa Aaaaaa Aa Aaa Aaaaaaaaaaaaa Aaaaaaaaaaaaa Aaaa a Aaaaa Aaaaaaa Aaaaaaaaaa Aaaaaaa Aaaaaaa Aa Aa Aaaaaaaaaaa Aaaaa Aaaaaaa Aaaaaaaaaaaaaa Aaa Aaaaaaaa Aaaaaa Aa Aaaaaaaaa Aaaaaaaa

a Aaaaa Aaaaaaaa Aaaaaaaaaaaa Aaa Aaaaaaaaa Aaaa Aaaaa Aaaaa Aaaaa Aa Aaa Aaaaaa Aaaa Aa Aaaaaaaa Aaaa Aaaaaaaa Aa Aaa Aaaaaaaaaaaaaaa Aaaaaa Aa Aaa Aaaaaa Aaaa Aa Aaaaaaaaaaaaaaaaaa Aa Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa Aaaaa Aaaaaaaaaaa Aaaaaaaaa Aaaa Aaa Aaaaa Aaaaaa Aaa Aaaaaaa Aaa Aaaaa Aaaaa Aaaaaaa Aaaaa Aaa Aaaa Aaa Aaaa Aaaaa a Aaaaaaaaaaa Aaaaaaa Aa Aaaaaaaaaaa Aaaaa

a Aaaaaaaaaaaaaaaaa Aa Aaaaaa Aaaaaaaaa Aaaaaaaaaaaaaaaaaaaa Aaaaa Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa Aa Aa Aaaaaaaa Aaaaaa Aaaaa Aaaaa Aaa Aaaaaaaaaaa Aaaaaa Aa Aaaaaaaaaaaa Aa Aaa Aaaaaaaaa Aa Aaaaaaaaaaaa Aaaaaa Aa Aaa Aaaaaaaaaaa Aaaaaaaa Aaaa Aaaa Aaa Aaaa Aaaaaa Aaaaaaaaaaaaa Aaaaaa Aaaaaaa Aaaaaa Aaaaaaaa Aa Aa Aaaaaaaa Aaa Aaaaaaaaaaaa Aaaaa Aaaaa Aaaa Aa Aaaaaaaa Aaa Aaaa Aaa Aaaaa Aaaaaaa

a Aaaaa Aaaaaaaaaaaaaaaa Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa Aaa Aaaaaaaa Aa Aaaaa Aaa Aaa Aaaaaaaaaaaaa Aaaaaa Aaaaaa Aaaa Aaaaaa Aaaaaa Aaaaaaaaa Aa Aaa Aaaa Aa Aaaaaaaaaaaaaaaaaaa Aaaaaaaa Aaaaaa Aaaa a Aaaaaaaaa Aaaaaaaaaaaaaaaaa Aaaa a Aaaaaaaaaa Aaaaaaaaaaaaa Aaaaa Aa Aaa Aaaaaaa Aaaaaaaa

🔒

New multi-array result type with cross-layer semantic constraints — audit directions cover data alignment, key identity, and deserialization timing.

Subscribe to read more